This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] libgcj enable hash_syncronization & pthread_slow on darwin


Bryce McKinlay wrote:

Andreas Tobler wrote:

the attached patch enables enable_hash_synchronization_default and slow_pthread_self on darwin. The hash sync part is necessary to get some swing stuff working. Without we hang forever.
About the benefit of slow_pthread_self I'm not quite sure. Maybe it would help on a G5?



I do wonder if slow_pthread_self is neccessary on darwin. Presumably/hopefully their ABI has a fast way to get the Thread ID? If so then then the slow_pthread_self implementation may actually end up being slower than a pthread_self() call, because it requires a read barrier. We plan to remove slow_pthread_self eventually for Linux, once most people are using nptl.


Otherwise, this patch looks good.

Thanks!


I give it a test run without slow_pthread_self.
Is there an easy method to check the performance?

Regards,
Andreas


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]