This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Java: Fix PR 1262
- From: Andrew Haley <aph at redhat dot com>
- To: Bryce McKinlay <mckinlay at redhat dot com>
- Cc: java-patches at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: Tue, 29 Jun 2004 10:38:05 +0100
- Subject: Java: Fix PR 1262
- References: <40E0DBB3.1040701@redhat.com>
Bryce McKinlay writes:
> 2004-06-28 Bryce McKinlay <mckinlay@redhat.com>
>
> PR java/1262
> * class.c (layout_class_method): Do not override package-private
> method if its in a different package.
it's
> (split_qualified_name): Move here from parse.y. Rename from
> breakdown_qualified. Add comment.
> (in_same_package): Move here from parse.y. Add comment.
> * java-tree.h (break_down_qualified, in_same_package): Declare.
> (in_same_package): Likewise.
> * parse.y (breakdown_qualified, in_same_package): Moved to class.c.
> Callers updated.
This is good. However, moving and/or renaming existing functions
places an additional burden on maintainers, so I would urge everyone
to consider carefully before making such changes. If you think it's
neccessary to do so in this case, go ahead.
Andrew.