This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [patch] Implement java.beans.Expression
- From: Tom Tromey <tromey at redhat dot com>
- To: Jerry Quinn <jlquinn at optonline dot net>
- Cc: java-patches at gcc dot gnu dot org
- Date: 28 Jun 2004 15:23:13 -0600
- Subject: Re: [patch] Implement java.beans.Expression
- References: <16602.25183.91510.49010@localhost.localdomain>
- Reply-to: tromey at redhat dot com
>>>>> "Jerry" == Jerry Quinn <jlquinn@optonline.net> writes:
Jerry> Mauve test checked in and passes.
Excellent.
Jerry> 2004-06-24 Jerry Quinn <jlquinn@optonline.net>
Jerry> * java/beans/Expression.java: New.
Jerry> * Makefile.am: Add Expression.java.
Jerry> * Makefile.in: Regenerate.
Looks good. Thanks for doing this. Just two little style nits.
Jerry> + public Expression(Object value, Object target, String methodName, Object[] arguments)
This looks longer than 80 chars, so wrap after one of the ","s.
You can just commit with this change.
Jerry> + public void setValue(Object value) { this.value = value; }
This needs the multi-line treatment.
Tom