This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] java.beans.Statement - Take 3

>>>>> "Jerry" == Jerry Quinn <jlquinn@optonline.net> writes:

Jerry> 2004-06-20  Jerry Quinn  <jlquinn@optonline.net>
Jerry> 	* Makefile.am (awt_java_source_files): Add Statement.java.
Jerry> 	* Makefile.in: Regenerate.
Jerry> 	* java/beans/Statement.java: New file.

This looks good to me.  Great work writing Mauve tests, btw, I wish
everyone would do this.

Jerry> +  public void execute() throws Exception { doExecute(); }

We don't usually have single-line methods like this, instead the body
has to be treated like any other method body.  Could you make this
change?  You don't have to re-submit the patch, just make the edit and
check it in.

Tom
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]