This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: BasicMenUI calls protected JMenu methods
- From: Olga Rodimina <rodimina at redhat dot com>
- To: Mark Wielaard <mark at klomp dot org>
- Cc: java-patches at gcc dot gnu dot org
- Date: 28 Jun 2004 09:43:49 -0400
- Subject: Re: BasicMenUI calls protected JMenu methods
- Organization:
- References: <1088256500.2711.105.camel@localhost>
On Sat, 2004-06-26 at 09:28, Mark Wielaard wrote:
> Hi,
>
> While integrating the latest gui-branch drop into GNU Classpath and
> testing with the jikes 2.21 compiler I noticed that BasicMenUI calls two
> protected JMenu methods. I fixed those by just removing them:
>
> 2004-06-26 Mark Wielaard <mark@klomp.org>
>
> * javax/swing/plaf/basic/BasicMenuUI.java (mousePressed): Don't call
> protected JMenu methods fireMenuCanceled() and fireMenuSelected().
>
> It looks like the MenuSelectionManager should take care of this when
> clearSelectedPath() or setSelectedPath() is called.
>
Yes, these methods should be called by JMenu's menuSelectiongChanged()
which is invoked by MenuSelectionManager. I already committed a patch to
fix this on Jun 22 to java-gui-branch, but this fix is not in mainline
yet.
--
Olga Rodimina <rodimina@redhat.com>