Re: PATCH win32/mingw32: jcf_open_exact_case prototype

[Andrew Haley <aph at redhat dot com>]

Mohan Embar writes:
 > Hi People,
 > 
 > > > I've been applying the following patch to fix a no previous prototype
 > > > warning that causes bootstrap to fail at werror.  Including the header
 > > > that prototypes jcf_open_exact_case causes lots of undefined symbol
 > > > warnings, and so it seems this is not the way to do this, so I just
 > > > simply prototype the function near the other file prototypes.
 > > > 
 > > > I don't know if this is the right way to fix this warning.
 > >
 > >Mohan, could you please sort this out?
 > 
 > I was able to reproduce this and fix this by including both coretypes.h
 > and jcf.h.
 > 
 > ...<i>but</i> if #include "jcf.h" can't be done without #include "coretypes.h",
 > wouldn't it be better to include coretypes.h in jcf.h and eliminate the
 > double-include everywhere else?

That depends.  Files that use "coretypes.h" should include it,
regardless of whether "jcf.h" includes it.  But they shouldn't have to
include "coretypes.h" themselves if they don't use anything in it.

 > Let me know either way and I'll submit a patch.

Please do the right thing.

Andrew.