This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: recent regression
- From: Ranjit Mathew <rmathew at gmail dot com>
- To: Bryce McKinlay <mckinlay at redhat dot com>
- Cc: Andrew Haley <aph at redhat dot com>, java-patches at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: Sun, 27 Jun 2004 23:50:16 +0530
- Subject: Re: recent regression
- References: <87y8mcol88.fsf@fleche.redhat.com> <40DBC43C.10903@gmail.com> <16603.56888.230716.359472@cuddles.cambridge.redhat.com> <39399b9d04062502026cf7bba2@mail.gmail.com> <16603.60059.360817.29284@cuddles.cambridge.redhat.com> <40DC475C.7060608@redhat.com> <39399b9d04062509517c41324@mail.gmail.com> <40DC9B36.1000701@redhat.com>
On Fri, 25 Jun 2004 17:37:58 -0400, Bryce McKinlay <mckinlay@redhat.com> wrote:
>
>
> Ranjit Mathew wrote:
>
> >>Would it not it be better to simply avoid calling read_class in the
> >>CLASS_FROM_SOURCE_P case? If you have a type decl for a class and
> >>CLASS_FROM_SOURCE_P is true, then (afaik) it must by definition be
> >>already loaded and been/being parsed. How about the following patch instead:
> >>
> >>
> >[...]
> >
> >
> >>This would also allow us to get rid of many of the CLASS_FROM_SOURCE_P
> >>checks scattered around parse.y.
[...]
> Agreed. Here's a complete patch with redundant CLASS_FROM_SOURCE_P's
> removed. I've run this through the testsuite (no regressions), and also
> built parts of RHUG against it. It seems to fix PR 16768 as well.
Bryce,
You might want to simplify this idiom in other files (not just parse.y)
as well.
Ranjit.