This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: PATCH win32/mingw32: jcf_open_exact_case prototype
- From: Mohan Embar <gnustuff at thisiscool dot com>
- To: java-patches at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org, Andrew Haley <aph at redhat dot com>, aaronavay62 at aaronwl dot com, tromey at redhat dot com
- Date: Sun, 27 Jun 2004 09:57:56 -0500
- Subject: Re: PATCH win32/mingw32: jcf_open_exact_case prototype
- Reply-to: gnustuff at thisiscool dot com
Hi People,
> > I've been applying the following patch to fix a no previous prototype
> > warning that causes bootstrap to fail at werror. Including the header
> > that prototypes jcf_open_exact_case causes lots of undefined symbol
> > warnings, and so it seems this is not the way to do this, so I just
> > simply prototype the function near the other file prototypes.
> >
> > I don't know if this is the right way to fix this warning.
>
>Mohan, could you please sort this out?
I was able to reproduce this and fix this by including both coretypes.h
and jcf.h.
...<i>but</i> if #include "jcf.h" can't be done without #include "coretypes.h",
wouldn't it be better to include coretypes.h in jcf.h and eliminate the
double-include everywhere else? coretypes.h has an include guard so
this shouldn't be a problem.
Let me know either way and I'll submit a patch.
P.S. Aaron: are you building the mainline on MinGW? If so, how are
you able to get past the breakage in libmudflap in mf-runtime.c? I
had to revert to the 23-06-2004 CVS version to get past this
temporarily. I haven't spent much time looking into the causes
of this and don't even know who owns libmudflap.