This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [Bug other/15194] [fastjar] Check for "long long" before using it
- From: Alexandre Oliva <aoliva at redhat dot com>
- To: Kelley Cook <kcook at gcc dot gnu dot org>
- Cc: GCC Bug Database <gcc-bugzilla at gcc dot gnu dot org>, GCC Patches <gcc-patches at gcc dot gnu dot org>, GCJ-patches <java-patches at gcc dot gnu dot org>, Paolo Bonzini <bonzini at gnu dot org>, Nathanael Nerode <neroden at twcny dot rr dot com>
- Date: 25 Jun 2004 15:57:50 -0300
- Subject: Re: [Bug other/15194] [fastjar] Check for "long long" before using it
- Organization: Red Hat Global Engineering Services Compiler Team
- References: <40DC4524.10905@gcc.gnu.org>
On Jun 25, 2004, Kelley Cook <kcook@gcc.gnu.org> wrote:
> 2004-06-25 Kelley Cook <kcook@gcc.gnu.org>
> * configure.ac: Add check for long long.
> * jartool.h: Check for long long before using it.
> * configure: Regenerate
> * config.h.in: Regenerate.
Ok, thanks.
> -#elif SIZEOF_LONG_LONG == 4
> +#elif defined(HAVE_LONG_LONG) && SIZEOF_LONG_LONG == 4
You don't really need this, BTW. If an identifier referenced in a
preprocessor clause is undefined, it evaluates to 0. I'm told some
compilers issue gratuitous warnings for such cases, though, so the
change is good. Please check it in.
--
Alexandre Oliva http://www.ic.unicamp.br/~oliva/
Red Hat Compiler Engineer aoliva@{redhat.com, gcc.gnu.org}
Free Software Evangelist oliva@{lsd.ic.unicamp.br, gnu.org}