This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [patch] Implement java.beans.Expression
- From: jlquinn at optonline dot net
- To: Mark Wielaard <mark at klomp dot org>
- Cc: java-patches at gcc dot gnu dot org
- Date: Fri, 25 Jun 2004 11:27:58 -0400
- Subject: Re: [patch] Implement java.beans.Expression
> Hi,
>
> On Thu, 2004-06-24 at 07:10, Jerry Quinn wrote:
> > This depends on http://gcc.gnu.org/ml/java-patches/2004-q2/msg00739.html
> >
> > 2004-06-24 Jerry Quinn <jlquinn@optonline.net>
> >
> > * java/beans/Expression.java: New.
> > * Makefile.am: Add Expression.java.
> > * Makefile.in: Regenerate.
>
> Very nice. Thanks for working on these classes.
> Are you still waiting for approval to check them in?
Thanks. Both the Expression.java and Statement.java patches are waiting for
approval.
> I quickly tried them by adding them to GNU Classpath.
> It gave one Mauve failure though with jamvm
> (thanks for writing Mauve tests btw!).
[snip]
> That didn't work for me since klazz now points to java.lang.Class which
> doesn't have any constructors. My quick and dirty patch to get all mauve
> tests working was to change the assignment of klazz to:
>
> Class klazz = (target instanceof Class)
> ? (Class) target : target.getClass();
>
> What do you think?
I also discovered this while testing Expression and have an equivalent fix in
my Statement.java, but hadn't posted it. Yours is cleaner, though.
Thanks,
Jerry