Re: [patch] java.beans.Statement

[Michael Koch <konqueror at gmx dot de>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am Sonntag, 20. Juni 2004 06:17 schrieb Jerry Quinn:
> This is an initial implementation of java.beans.Statement.  There's
> now a mauve test that this class passes.
>
>
> 2004-06-20  Jerry Quinn  <jlquinn@optonline.net>
>
> 	* java/beans/Statement.java: New file.

New files need to be added to Makefile.am and Makefile.in need to be 
regenerated with automake-gcj.

> +import java.lang.reflect.*;

We prefer explicit imports.

> +  Object target;
> +  String methodName;
> +  Object[] arguments;

Is there a reason what these are not private ?

> +   * Constructor
> +   *

You can leave these two lines out.

> +   * @throws Exception.

This needs an explanation I think.

> +      if (c == wrappers[i]) return natives[i];

This needs to be wrapped into two lines.

> +    for (int i=0; i < params.length; i++)

Our coding style says space before and after '='.

> +  // A method is more specific if all parameters can also be fed
> to +  // the less specific method, because, e.g. the less specific
> method +  // accepts a base class of the equivalent argument for
> the more +  // specific one.

This should be normal javadocs comments then it is possible to 
generate javadoc API with documentation for private methods too.

I have only looked at the style currently. I trust you that 
functionality is working. I haven't tried. Please update when resend 
the patch. Tom can than look at it for approving.


Michael
- -- 
Homepage: http://www.worldforge.org/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFA1Tj+WSOgCCdjSDsRAoT2AKCANW0ZDZZlqTp/uIU3QFbLenMudwCeP3E5
dQLIkzjbU6S4Di2R9A5NMK8=
=UO5L
-----END PGP SIGNATURE-----