This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[gui] [PATCH] Revert patch to Component.remove()


Hi,

I'm reverting my previous patch to Component.remove() in the
java-gui-branch.  It turns out that a removed component should not be
set to invisible.  The bug I was trying to fix was actually caused by
JButton.removeNotify(), which is only stubbed at the moment.

-David Jee

2004-06-09  David Jee  <djee@redhat.com>

        * java/awt/Container.java
        (remove): Do not set component to invisible.

Index: java/awt/Container.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/java/awt/Container.java,v
retrieving revision 1.34.2.10
diff -u -r1.34.2.10 Container.java
--- java/awt/Container.java	31 May 2004 14:19:09 -0000	1.34.2.10
+++ java/awt/Container.java	9 Jun 2004 20:24:19 -0000
@@ -419,7 +419,6 @@
           layoutMgr.removeLayoutComponent(r);
 
         r.parent = null;
-        r.setVisible(false);
 
         // Post event to notify of adding the container.
         ContainerEvent ce = new ContainerEvent(this,

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]