This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
[java] Add missing SimpleTimeZone members
- From: Jerry Quinn <jlquinn at optonline dot net>
- To: java-patches at gcc dot gnu dot org
- Date: Fri, 23 Apr 2004 18:01:21 -0400
- Subject: [java] Add missing SimpleTimeZone members
This patch adds all the missing members for SimpleTimeZone.
Jerry Quinn
2004-04-23 Jerry Quinn <jlquinn@optonline.net>
* java/util/SimpleTimeZone.java (startTimeMode, endTimeMode,
WALL_TIME, STANDARD_TIME, UTC_TIME): New members.
(SimpleTimeZone): Tweak docs. Add new variation.
(setStartRule,setEndRule): Add new variations. Use
startTimeMode and endTimeMode.
*** SimpleTimeZone.java.~1.10.~ Sun Apr 18 17:45:00 2004
--- SimpleTimeZone.java Fri Apr 23 17:54:41 2004
***************
*** 1,5 ****
/* java.util.SimpleTimeZone
! Copyright (C) 1998, 1999, 2000, 2003 Free Software Foundation, Inc.
This file is part of GNU Classpath.
--- 1,5 ----
/* java.util.SimpleTimeZone
! Copyright (C) 1998, 1999, 2000, 2003, 2004 Free Software Foundation, Inc.
This file is part of GNU Classpath.
***************
*** 146,152 ****
* @serial
*/
private int startTime;
!
/**
* The month in which daylight savings ends. This is one of the
* constants Calendar.JANUARY, ..., Calendar.DECEMBER.
--- 146,160 ----
* @serial
*/
private int startTime;
!
! /**
! * This variable specifies the mode that startTime is specified in. By
! * default it is WALL_TIME, but can also be STANDARD_TIME or UTC_TIME. For
! * startTime, STANDARD_TIME and WALL_TIME are equivalent.
! * @serial
! */
! private int startTimeMode = WALL_TIME;
!
/**
* The month in which daylight savings ends. This is one of the
* constants Calendar.JANUARY, ..., Calendar.DECEMBER.
***************
*** 186,191 ****
--- 194,206 ----
private int endTime;
/**
+ * This variable specifies the mode that endTime is specified in. By
+ * default it is WALL_TIME, but can also be STANDARD_TIME or UTC_TIME.
+ * @serial
+ */
+ private int endTimeMode = WALL_TIME;
+
+ /**
* This variable points to a deprecated array from JDK 1.1. It is
* ignored in JDK 1.2 but streamed out for compatibility with JDK 1.1.
* The array contains the lengths of the months in the year and is
***************
*** 224,229 ****
--- 239,261 ----
private static final long serialVersionUID = -403250971215465050L;
/**
+ * Constant to indicate that start and end times are specified in standard
+ * time, without adjusting for daylight savings.
+ */
+ public static final int STANDARD_TIME = 1;
+
+ /**
+ * Constant to indicate that start and end times are specified in wall
+ * time, adjusting for daylight savings. This is the default.
+ */
+ public static final int WALL_TIME = 0;
+
+ /**
+ * Constant to indicate that start and end times are specified in UTC.
+ */
+ public static final int UTC_TIME = 2;
+
+ /**
* Create a <code>SimpleTimeZone</code> with the given time offset
* from GMT and without daylight savings.
* @param rawOffset the time offset from GMT in milliseconds.
***************
*** 283,289 ****
* @param endday A day in month or a day of week number, as
* described above.
* @param endDayOfWeek The end rule day of week; see above.
! * @param endTime A time in millis in standard time. */
public SimpleTimeZone(int rawOffset, String id,
int startMonth, int startDayOfWeekInMonth,
int startDayOfWeek, int startTime,
--- 315,324 ----
* @param endday A day in month or a day of week number, as
* described above.
* @param endDayOfWeek The end rule day of week; see above.
! * @param endTime A time in millis in standard time.
! * @throws IllegalArgumentException if parameters are invalid or out of
! * range.
! */
public SimpleTimeZone(int rawOffset, String id,
int startMonth, int startDayOfWeekInMonth,
int startDayOfWeek, int startTime,
***************
*** 310,315 ****
--- 345,351 ----
*
* @param dstSavings the amount of savings for daylight savings
* time in milliseconds. This must be positive.
+ * @since 1.2
*/
public SimpleTimeZone(int rawOffset, String id,
int startMonth, int startDayOfWeekInMonth,
***************
*** 325,330 ****
--- 361,402 ----
}
/**
+ * This constructs a new SimpleTimeZone that supports a daylight savings
+ * rule. The parameter are the same as for the constructor above, except
+ * there are the additional startTimeMode, endTimeMode, and dstSavings
+ * parameters.
+ *
+ * @param startTimeMode the mode that start times are specified in. One of
+ * WALL_TIME, STANDARD_TIME, or UTC_TIME.
+ * @param endTimeMode the mode that end times are specified in. One of
+ * WALL_TIME, STANDARD_TIME, or UTC_TIME.
+ * @param dstSavings the amount of savings for daylight savings
+ * time in milliseconds. This must be positive.
+ * @throws IllegalArgumentException if parameters are invalid or out of
+ * range.
+ * @since 1.4
+ */
+ public SimpleTimeZone(int rawOffset, String id,
+ int startMonth, int startDayOfWeekInMonth,
+ int startDayOfWeek, int startTime, int startTimeMode,
+ int endMonth, int endDayOfWeekInMonth,
+ int endDayOfWeek, int endTime, int endTimeMode,
+ int dstSavings)
+ {
+ this(rawOffset, id,
+ startMonth, startDayOfWeekInMonth, startDayOfWeek, startTime,
+ endMonth, endDayOfWeekInMonth, endDayOfWeek, endTime);
+
+ if (startTimeMode < WALL_TIME || startTimeMode > UTC_TIME)
+ throw new IllegalArgumentException("startTimeMode must be one of WALL_TIME, STANDARD_TIME, or UTC_TIME");
+ if (endTimeMode < WALL_TIME || endTimeMode > UTC_TIME)
+ throw new IllegalArgumentException("endTimeMode must be one of WALL_TIME, STANDARD_TIME, or UTC_TIME");
+ this.startTimeMode = startTimeMode;
+ this.endTimeMode = endTimeMode;
+ this.dstSavings = dstSavings;
+ }
+
+ /**
* Sets the first year, where daylight savings applies. The daylight
* savings rule never apply for years in the BC era. Note that this
* is gregorian calendar specific.
***************
*** 400,417 ****
// of this method.
this.startDay = Math.abs(day);
this.startDayOfWeek = Math.abs(dayOfWeek);
! this.startTime = time;
useDaylight = true;
}
/**
* Sets the daylight savings end rule. You must also set the
* start rule with <code>setStartRule</code> or the result of
* getOffset is undefined. For the parameters see the ten-argument
* constructor above.
*
- * @param rawOffset The time offset from GMT.
- * @param id The identifier of this time zone.
* @param month The end month of daylight savings.
* @param day A day in month, or a day of week in month.
* @param dayOfWeek A day of week, when daylight savings ends.
--- 472,547 ----
// of this method.
this.startDay = Math.abs(day);
this.startDayOfWeek = Math.abs(dayOfWeek);
! if (this.startTimeMode == WALL_TIME || this.startTimeMode == STANDARD_TIME)
! this.startTime = time;
! else
! // Convert from UTC to STANDARD
! this.startTime = time - this.rawOffset;
! useDaylight = true;
! }
!
! /**
! * Sets the daylight savings start rule. You must also set the
! * end rule with <code>setEndRule</code> or the result of
! * getOffset is undefined. For the parameters see the ten-argument
! * constructor above.
! *
! * @param month The month where daylight savings start, zero
! * based. You should use the constants in Calendar.
! * @param day A day of month or day of week in month.
! * @param dayOfWeek The day of week where daylight savings start.
! * @param time The time in milliseconds standard time where daylight
! * savings start.
! * @param after If true, day and dayOfWeek specify first day of week on or
! * after day, else first day of week on or before.
! * @since 1.2
! * @see SimpleTimeZone
! */
! public void setStartRule(int month, int day, int dayOfWeek, int time, boolean after)
! {
! // FIXME: XXX: Validate that checkRule and offset processing work with on
! // or before mode.
! this.startDay = after ? Math.abs(day) : -Math.abs(day);
! this.startDayOfWeek = after ? Math.abs(dayOfWeek) : -Math.abs(dayOfWeek);
! this.startMode = checkRule(month, day, dayOfWeek);
! this.startDay = Math.abs(this.startDay);
! this.startDayOfWeek = Math.abs(this.startDayOfWeek);
!
! this.startMonth = month;
!
! if (this.startTimeMode == WALL_TIME || this.startTimeMode == STANDARD_TIME)
! this.startTime = time;
! else
! // Convert from UTC to STANDARD
! this.startTime = time - this.rawOffset;
useDaylight = true;
}
/**
+ * Sets the daylight savings start rule. You must also set the
+ * end rule with <code>setEndRule</code> or the result of
+ * getOffset is undefined. For the parameters see the ten-argument
+ * constructor above.
+ *
+ * @param month The month where daylight savings start, zero
+ * based. You should use the constants in Calendar.
+ * @param day A day of month or day of week in month.
+ * @param time The time in milliseconds standard time where daylight
+ * savings start.
+ * @see SimpleTimeZone
+ * @since 1.2
+ */
+ public void setStartRule(int month, int day, int time)
+ {
+ setStartRule(month, day, 0, time);
+ }
+
+ /**
* Sets the daylight savings end rule. You must also set the
* start rule with <code>setStartRule</code> or the result of
* getOffset is undefined. For the parameters see the ten-argument
* constructor above.
*
* @param month The end month of daylight savings.
* @param day A day in month, or a day of week in month.
* @param dayOfWeek A day of week, when daylight savings ends.
***************
*** 426,436 ****
// of this method.
this.endDay = Math.abs(day);
this.endDayOfWeek = Math.abs(dayOfWeek);
! this.endTime = time;
useDaylight = true;
}
/**
* Gets the time zone offset, for current date, modified in case of
* daylight savings. This is the offset to add to UTC to get the local
* time.
--- 556,628 ----
// of this method.
this.endDay = Math.abs(day);
this.endDayOfWeek = Math.abs(dayOfWeek);
! if (this.endTimeMode == WALL_TIME)
! this.endTime = time;
! else if (this.endTimeMode == STANDARD_TIME)
! // Convert from STANDARD to DST
! this.endTime = time + this.dstSavings;
! else
! // Convert from UTC to DST
! this.endTime = time - this.rawOffset + this.dstSavings;
! useDaylight = true;
! }
!
! /**
! * Sets the daylight savings end rule. You must also set the
! * start rule with <code>setStartRule</code> or the result of
! * getOffset is undefined. For the parameters see the ten-argument
! * constructor above.
! *
! * @param month The end month of daylight savings.
! * @param day A day in month, or a day of week in month.
! * @param dayOfWeek A day of week, when daylight savings ends.
! * @param time A time in millis in standard time.
! * @param after If true, day and dayOfWeek specify first day of week on or
! * after day, else first day of week on or before.
! * @since 1.2
! * @see #setStartRule
! */
! public void setEndRule(int month, int day, int dayOfWeek, int time, boolean after)
! {
! // FIXME: XXX: Validate that checkRule and offset processing work with on
! // or before mode.
! this.endDay = after ? Math.abs(day) : -Math.abs(day);
! this.endDayOfWeek = after ? Math.abs(dayOfWeek) : -Math.abs(dayOfWeek);
! this.endMode = checkRule(month, day, dayOfWeek);
! this.endDay = Math.abs(this.endDay);
! this.endDayOfWeek = Math.abs(endDayOfWeek);
!
! this.endMonth = month;
!
! if (this.endTimeMode == WALL_TIME)
! this.endTime = time;
! else if (this.endTimeMode == STANDARD_TIME)
! // Convert from STANDARD to DST
! this.endTime = time + this.dstSavings;
! else
! // Convert from UTC to DST
! this.endTime = time - this.rawOffset + this.dstSavings;
useDaylight = true;
}
/**
+ * Sets the daylight savings end rule. You must also set the
+ * start rule with <code>setStartRule</code> or the result of
+ * getOffset is undefined. For the parameters see the ten-argument
+ * constructor above.
+ *
+ * @param month The end month of daylight savings.
+ * @param day A day in month, or a day of week in month.
+ * @param dayOfWeek A day of week, when daylight savings ends.
+ * @param time A time in millis in standard time.
+ * @see #setStartRule
+ */
+ public void setEndRule(int month, int day, int dayOfWeek, int time)
+ {
+ setEndRule(month, day, 0, time);
+ }
+
+ /**
* Gets the time zone offset, for current date, modified in case of
* daylight savings. This is the offset to add to UTC to get the local
* time.