Re: gtk-peer compile fixes for gcc-2.95

[Mark Wielaard <mark at klomp dot org>]

Hi,

On Fri, 2004-04-09 at 16:16, Thomas Fitzsimmons wrote:
> On Fri, 2004-04-09 at 17:34, Mark Wielaard wrote:
> > With this I believe the only things that make the native sources
> > uncompilable with gcc-2.95 are the following:
> > 
> > ../../../../classpath-cvs/native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkComponentPeer.c:670: warning: ISO C forbids passing arg 6 of `g_signal_handlers_block_matched' between function pointer and `void *'
> > ../../../../classpath-cvs/native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkComponentPeer.c: In function `Java_gnu_java_awt_peer_gtk_GtkComponentPeer_removeExposeFilter':
> > ../../../../classpath-cvs/native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkComponentPeer.c:714: warning: ISO C forbids passing arg 6 of `g_signal_handlers_disconnect_matched' between function pointer and `void *'
> > ../../../../classpath-cvs/native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkComponentPeer.c:716: warning: ISO C forbids passing arg 6 of `g_signal_handlers_unblock_matched' between function pointer and `void *'
> > 
> > Could one of the gtk-peer hackers look at those?
> > It seems just casting the argument to a gpointer fixes all, but there is
> > some c macro magic going on here.
> 
> Try updating your source tree.  These calls seem to have been replaced
> with other GLib functions (at least on Classpath HEAD and libgcj
> java-gui-branch).

You didn't think I would check something in when I hadn't tested it
against the latest and greatest CVS source did you :)

Although the warning messages refer to `g_signal_handlers_block_matched'
and `g_signal_handlers_unblock_matched' and complains about argument 6
that isn't what our source actually calls (that is way I said that there
is some C macro magic going on). The source in question actually calls
'g_signal_handlers_block_by_func',
'g_signal_handlers_disconnect_by_func' and
'g_signal_handlers_unblock_by_func' which have only 3 arguments.

Cheers,

Mark

Attachment: signature.asc
Description: This is a digitally signed message part