This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: PATCH to optimize two Channels methods
- From: Richard Earnshaw <rearnsha at arm dot com>
- To: Per Bothner <per at bothner dot com>
- Cc: Richard Earnshaw <rearnsha at arm dot com>, Michael Koch <konqueror at gmx dot de>, java-patches at gcc dot gnu dot org
- Date: Sat, 13 Mar 2004 14:12:07 +0000
- Subject: Re: PATCH to optimize two Channels methods
- Organization: ARM Ltd.
- Reply-to: Richard Earnshaw <rearnsha at arm dot com>
> I didn't realize that configure overrides $PLATFORM with the more
> specific $FILE for natFile.cc and in the old version
> java/io/natFileDescriptor.cc. Thus you probably need to edit
> configure.in
> -AC_LINK_FILES(gnu/java/nio/channels/natFileChannel${PLATFORM}.cc,
> gnu/java/nio/channels/natFileChannelImpl.cc)
> +AC_LINK_FILES(gnu/java/nio/channels/natFileChannel${FILE-${PLATFORM}}.cc,
> gnu/java/nio/channels/natFileChannelImpl.cc)
>
> and configure:
> -ac_sources="include/$PLATFORMH java/io/natFile${FILE-${PLATFORM}}.cc
> java/lang/${PLATFORM}Process.java java/lang/nat${PLATFORM}Process.cc
> java/net/natInetAddress${PLATFORMNET}.cc
> java/net/natNetworkInterface${PLATFORMNET}.cc
> gnu/java/net/natPlainSocketImpl${PLATFORMNET}.cc
> gnu/java/net/natPlainDatagramSocketImpl${PLATFORMNET}.cc
> gnu/java/nio/natPipeImpl${PLATFORM}.cc
> gnu/java/nio/natSelectorImpl${PLATFORM}.cc
> gnu/java/nio/channels/natFileChannel${PLATFORM}.cc include/$GCHDR
> include/$THREADH sysdep/$sysdeps_dir/locks.h $SIGNAL_HANDLER
> $SIGNAL_HANDLER_AUX"
> +ac_sources="include/$PLATFORMH java/io/natFile${FILE-${PLATFORM}}.cc
> java/lang/${PLATFORM}Process.java java/lang/nat${PLATFORM}Process.cc
> java/net/natInetAddress${PLATFORMNET}.cc
> java/net/natNetworkInterface${PLATFORMNET}.cc
> gnu/java/net/natPlainSocketImpl${PLATFORMNET}.cc
> gnu/java/net/natPlainDatagramSocketImpl${PLATFORMNET}.cc
> gnu/java/nio/natPipeImpl${PLATFORM}.cc
> gnu/java/nio/natSelectorImpl${PLATFORM}.cc
> gnu/java/nio/channels/natFileChannelnatFile${FILE-${PLATFORM}}.cc
> include/$GCHDR include/$THREADH sysdep/$sysdeps_dir/locks.h
> $SIGNAL_HANDLER $SIGNAL_HANDLER_AUX"
>
I made the stupid mistake of updating configure.in but not configure, so
my first run showed no improvement at all :-(
Fixing configure with the above change does cure all the regressions apart
from a segmentaion fault when compiling simple.java (this is probably
unrelated).
> Really, the symlink mechanism is looking uglier and uglier
> the more I look at it.
Yep, the symlinks generally make it very hard to follow exactly what's
going on.
R.