This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PATCH to optimize two Channels methods

From: Richard Earnshaw <rearnsha at arm dot com>
To: Michael Koch <konqueror at gmx dot de>
Cc: Richard Earnshaw <rearnsha at arm dot com>, Per Bothner <per at bothner dot com>, java-patches at gcc dot gnu dot org
Date: Tue, 09 Mar 2004 11:41:32 +0000
Subject: Re: PATCH to optimize two Channels methods
Organization: ARM Ltd.
Reply-to: Richard Earnshaw <rearnsha at arm dot com>

> Am Dienstag, 9. März 2004 11:25 schrieb Richard Earnshaw:
> 
> > Is there any chance of this being fixed soon?  Or should I put in a
> > request for the offending patch(es) to be backed out?
> 
> I thought Per fixes his mess himself or says "no time, can someone 
> please do ?".
> 

Well I would normally hope for a reply rather than stony silence... :-(

> Anyway, I have written a short patch. Can you try it ?

Sorry, still get a load of errors:

/work/rearnsha/gnu/egcs/gcc/xgcc -shared-libgcc -B/work/rearnsha/gnu/egcs/g
cc/ -nostdinc++ -L/work/rearnsha/gnu/egcs/arm-elf/thumb/libstdc++-v3/src 
-L/work/rearnsha/gnu/egcs/arm-elf/thumb/libstdc++-v3/src/.libs -nostdinc 
-B/work/rearnsha/gnu/egcs/arm-elf/thumb/newlib/ -isystem 
/work/rearnsha/gnu/egcs/arm-elf/thumb/newlib/targ-include -isystem 
/home/rearnsha/gnusrc/egcs-cross/newlib/libc/include 
-B/work/rearnsha/gnu/testinstall/arm-elf/bin/ -B/work/rearnsha/gnu/testinst
all/arm-elf/lib/ -isystem /work/rearnsha/gnu/testinstall/arm-elf/include 
-isystem /work/rearnsha/gnu/testinstall/arm-elf/sys-include 
-L/work/rearnsha/gnu/egcs/ld -mthumb -DHAVE_CONFIG_H -I. 
-I/home/rearnsha/gnusrc/egcs-cross/libjava -I./include -I./gcj 
-I/home/rearnsha/gnusrc/egcs-cross/libjava -Iinclude 
-I/home/rearnsha/gnusrc/egcs-cross/libjava/include 
-I/home/rearnsha/gnusrc/egcs-cross/boehm-gc/include -DPACKAGE_NAME= 
-DPACKAGE_TARNAME= -DPACKAGE_VERSION= -DPACKAGE_STRING= 
-DPACKAGE_BUGREPORT= -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 
-DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_UNISTD_H=1 
-DSILENT=1 -DNO_SIGNALS=1 -DALL_INTERIOR_POINTERS=1 -DJAVA_FINALIZATION=1 
-DGC_GCJ_SUPPORT=1 -DATOMIC_UNCOLLECTABLE=1 -DNO_SIGSET=1 -DNO_DEBUGGING=1 
-I/home/rearnsha/gnusrc/egcs-cross/libjava/.././libjava/../gcc 
-I/home/rearnsha/gnusrc/egcs-cross/libjava/../zlib -O2 -g -O2 -fno-rtti 
-fnon-call-exceptions -fdollars-in-identifiers -Wswitch-enum 
-I/usr/X11R6/include -W -Wall -D_GNU_SOURCE -DPREFIX=\"/work/rearnsha/gnu/t
estinstall\" -DLIBDIR=\"/work/rearnsha/gnu/testinstall/lib\" 
-DBOOT_CLASS_PATH=\"/work/rearnsha/gnu/testinstall/share/java/libgcj-3.5.0.
jar\" -g -O2 -mthumb -MD -MT gnu/java/nio/channels/natFileChannelImpl.lo 
-MF gnu/java/nio/channels/natFileChannelImpl.pp -c 
gnu/java/nio/channels/natFileChannelImpl.cc -o gnu/java/nio/channels/natFil
eChannelImpl.o
gnu/java/nio/channels/natFileChannelImpl.cc:46: error: 
`java::nio::MappedByteBufferImpl' has not been declared
gnu/java/nio/channels/natFileChannelImpl.cc:50: error: `gnu::java' has not 
been declared
gnu/java/nio/channels/natFileChannelImpl.cc:50: error: expected 
nested-name-specifier before "FileChannelImpl"
gnu/java/nio/channels/natFileChannelImpl.cc:50: error: `FileChannelImpl' 
has not been declared
gnu/java/nio/channels/natFileChannelImpl.cc:53: error: `FileChannel' has 
not been declared
gnu/java/nio/channels/natFileChannelImpl.cc: In function `void init()':
gnu/java/nio/channels/natFileChannelImpl.cc:55: error: `in' was not 
declared in this scope
gnu/java/nio/channels/natFileChannelImpl.cc:55: error: `FileChannelImpl' 
has not been declared
gnu/java/nio/channels/natFileChannelImpl.cc:55: error: `FileChannelImpl' 
has not been declared
gnu/java/nio/channels/natFileChannelImpl.cc:55: error: `READ' was not 
declared in this scope
gnu/java/nio/channels/natFileChannelImpl.cc:56: error: `out' was not 
declared in this scope
gnu/java/nio/channels/natFileChannelImpl.cc:56: error: `FileChannelImpl' 
has not been declared
gnu/java/nio/channels/natFileChannelImpl.cc:56: error: `FileChannelImpl' 
has not been declared
gnu/java/nio/channels/natFileChannelImpl.cc:56: error: `WRITE' was not 
declared in this scope
gnu/java/nio/channels/natFileChannelImpl.cc:57: error: `err' was not 
declared in this scope
gnu/java/nio/channels/natFileChannelImpl.cc:57: error: `FileChannelImpl' 
has not been declared
gnu/java/nio/channels/natFileChannelImpl.cc:57: error: `FileChannelImpl' 
has not been declared
gnu/java/nio/channels/natFileChannelImpl.cc:55: warning: unused variable 
'in'
gnu/java/nio/channels/natFileChannelImpl.cc:55: warning: unused variable 
'READ'
gnu/java/nio/channels/natFileChannelImpl.cc:56: warning: unused variable 
'out'
gnu/java/nio/channels/natFileChannelImpl.cc:57: warning: unused variable 
'err'
gnu/java/nio/channels/natFileChannelImpl.cc: At global scope:
gnu/java/nio/channels/natFileChannelImpl.cc:80: error: `FileChannelImpl' 
has not been declared
gnu/java/nio/channels/natFileChannelImpl.cc: In function `jint 
open(java::lang::String*, jint)':
gnu/java/nio/channels/natFileChannelImpl.cc:82: error: `fd' was not 
declared in this scope
gnu/java/nio/channels/natFileChannelImpl.cc:82: warning: unused variable 
'fd'
gnu/java/nio/channels/natFileChannelImpl.cc: At global scope:
gnu/java/nio/channels/natFileChannelImpl.cc:86: error: `FileChannelImpl' 
has not been declared
gnu/java/nio/channels/natFileChannelImpl.cc:93: error: `FileChannelImpl' 
has not been declared
gnu/java/nio/channels/natFileChannelImpl.cc:104: error: `FileChannelImpl' 
has not been declared
gnu/java/nio/channels/natFileChannelImpl.cc:109: error: `FileChannelImpl' 
has not been declared
gnu/java/nio/channels/natFileChannelImpl.cc:114: error: `FileChannelImpl' 
has not been declared
gnu/java/nio/channels/natFileChannelImpl.cc:121: error: `FileChannelImpl' 
has not been declared
gnu/java/nio/channels/natFileChannelImpl.cc:127: error: `FileChannelImpl' 
has not been declared
gnu/java/nio/channels/natFileChannelImpl.cc:133: error: `FileChannelImpl' 
has not been declared
gnu/java/nio/channels/natFileChannelImpl.cc:139: error: `FileChannelImpl' 
has not been declared
gnu/java/nio/channels/natFileChannelImpl.cc:145: error: `FileChannelImpl' 
has not been declared
gnu/java/nio/channels/natFileChannelImpl.cc:151: error: `FileChannelImpl' 
has not been declared
gnu/java/nio/channels/natFileChannelImpl.cc:158: error: `FileChannelImpl' 
has not been declared
gnu/java/nio/channels/natFileChannelImpl.cc:165: error: `FileChannelImpl' 
has not been declared
gnu/java/nio/channels/natFileChannelImpl.cc: In function `jint 
open(java::lang::String*, jint)':
gnu/java/nio/channels/natFileChannelImpl.cc:81: warning: unused parameter 
'path'
gnu/java/nio/channels/natFileChannelImpl.cc:81: warning: unused parameter 
'jflags'
gnu/java/nio/channels/natFileChannelImpl.cc: In function `jint seek(jlong, 
jint, jboolean)':
gnu/java/nio/channels/natFileChannelImpl.cc:115: warning: unused parameter 
'pos'
gnu/java/nio/channels/natFileChannelImpl.cc:115: warning: unused parameter 
'whence'
gnu/java/nio/channels/natFileChannelImpl.cc: In function `jint 
read(JArray<jbyte>*, jint, jint)':
gnu/java/nio/channels/natFileChannelImpl.cc:140: warning: unused parameter 
'buffer'
gnu/java/nio/channels/natFileChannelImpl.cc:140: warning: unused parameter 
'offset'
gnu/java/nio/channels/natFileChannelImpl.cc:140: warning: unused parameter 
'count'
gnu/java/nio/channels/natFileChannelImpl.cc: In function `void lock(jlong, 
jint, jboolean)':
gnu/java/nio/channels/natFileChannelImpl.cc:152: warning: unused parameter 
'pos'
gnu/java/nio/channels/natFileChannelImpl.cc:152: warning: unused parameter 
'len'
gnu/java/nio/channels/natFileChannelImpl.cc:152: warning: unused parameter 
'shared'
gnu/java/nio/channels/natFileChannelImpl.cc: In function `jboolean 
tryLock(jlong, jint, jboolean)':
gnu/java/nio/channels/natFileChannelImpl.cc:159: warning: unused parameter 
'pos'
gnu/java/nio/channels/natFileChannelImpl.cc:159: warning: unused parameter 
'len'
gnu/java/nio/channels/natFileChannelImpl.cc:159: warning: unused parameter 
'shared'
gnu/java/nio/channels/natFileChannelImpl.cc: In function `void 
unlock(jlong, jint)':
gnu/java/nio/channels/natFileChannelImpl.cc:166: warning: unused parameter 
'pos'
gnu/java/nio/channels/natFileChannelImpl.cc:166: warning: unused parameter 
'len'


R.

Follow-Ups:
- Re: PATCH to optimize two Channels methods
  - From: Michael Koch
- Re: PATCH to optimize two Channels methods
  - From: Per Bothner

References:
- Re: PATCH to optimize two Channels methods
  - From: Michael Koch

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]