This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: _Jv_Debug


Tom Tromey writes:
 > >>>>> "Andrew" == Andrew Haley <aph@redhat.com> writes:
 > 
 > Andrew> +   // FIXME: We could just use getClass() here, but this is a
 > Andrew> +   // workaround for a C++ bug that is causing getClass() to be
 > Andrew> +   // miscompiled.
 > 
 > What if we put the PR number in this comment, so that in the future a
 > reader can know whether or not he can remove this workaround?

OK.

 > Andrew> + 	else if (getItsClass(thing) == String.class)
 > Andrew> [ ... ]
 > 
 > I think you must also special-case RawData here, as these aren't real
 > object references.  You could print them as hex values...

That's what the catch does.

Andrew.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]