This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [PATCH] Small fixes to AWT
- From: Thomas Fitzsimmons <fitzsim at redhat dot com>
- To: David Jee <djee at redhat dot com>
- Cc: libgcj patches <java-patches at gcc dot gnu dot org>
- Date: Tue, 10 Feb 2004 11:53:45 -0500
- Subject: Re: [PATCH] Small fixes to AWT
- References: <1076429260.23292.3.camel@tomboy.toronto.redhat.com>
On Tue, 2004-02-10 at 11:07, David Jee wrote:
> Hello,
>
> Here are some small fixes to AWT that came up while I was working on
> GridBagLayout. OK to commit?
>
> -David Jee
>
>
> 2004-02-10 David Jee <djee@redhat.com>
>
> * java/awt/BorderLayout.java
> (calcCompSize): Invisible components get zero dimensions.
This one is fine.
> * java/awt/Button.java
> (setLabel): Set actionCommand.
Likewise for this one.
> * java/awt/Component.java
> (show): Invalidate after show or hide.
>
What problem does this one fix? If invalidation really is needed
shouldn't it occur in show() and hide() themselves, since they can be
called directly?
Tom