This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [PATCH]: DatagramChannel + Misc. Channel Fixes
- From: Michael Koch <konqueror at gmx dot de>
- To: Mohan Embar <gnustuff at thisiscool dot com>
- Cc: Michael Koch <konqueror at gmx dot de>, GCJ Patches <java-patches at gcc dot gnu dot org>
- Date: Sun, 1 Feb 2004 19:00:15 +0100
- Subject: Re: [PATCH]: DatagramChannel + Misc. Channel Fixes
- References: <1Y3W97C0E9G2YCPN2UYVY2XWU0GB.401d3894@p733>
On Sun, Feb 01, 2004 at 11:34:12AM -0600, Mohan Embar wrote:
> Hi Michael,
>
> I updated my NetTest with a DatagramChannel test and then
> fixed libgcj to make this test work. Here is the patch,
> which is against the trunk but will assuredly apply cleanly
> to 3.4 also.
>
> (I will eventually put these into Mauve if someone doesn't
> do it before I do.)
>
> I needed yet another "in channel operation" indicator, but
> this time I needed to put it into DatagramChannelImpl instead
> of the datagram socket implementation, which I wasn't allowed
> to touch. I thought of a nice way of getting rid of some of
> this ugliness, but it's too far-reaching for 3.4 and I'd
> prefer getting this checked in first (if you like it) before
> proceeding with the refactoring.
>
> I've attached my updated NetTest as well as the output of
> this test under both Sun's JRE (1.4.1-rc-b19) and gcj. As
> I mentioned in a previous post, I believe that the
> "--> Interrupted!" lines in the gcj output which are
> not present in the Sun output are correct and that Sun's
> implementation is incorrect.
Can you recreate this as unified diff please ? Its much more readbale.
Michael