This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [PATCH] Rendering Hints and small bug in fill polygon
- From: Tom Tromey <tromey at redhat dot com>
- To: Olga Rodimina <rodimina at redhat dot com>
- Cc: java-patches at gcc dot gnu dot org
- Date: 13 Jan 2004 13:12:37 -0700
- Subject: Re: [PATCH] Rendering Hints and small bug in fill polygon
- References: <1074013613.18224.94.camel@toby.toronto.redhat.com>
- Reply-to: tromey at redhat dot com
>>>>> "Olga" == Olga Rodimina <rodimina@redhat.com> writes:
Olga> This patch modifies GdkGraphics2D to accept rendering hint
Olga> KEY_STROKE_CONTROL and normalizes certain paths when
Olga> KEY_STROKE_CONTROL is set to "NORMALIZE" mode. This patch also
Olga> implements some of the rendering hints related methods.
This looks ok to me, but there are some formatting nits to fix before
it can go in.
Olga> I've also fixed a small bug that caused polygons to be filled
Olga> incorrectly.
Ordinarily it is better to make a separate patch for an unrelated fix.
In this case it doesn't matter too much to me, but for future
reference...
Olga> + defaultHints.put (RenderingHints.KEY_TEXT_ANTIALIASING, RenderingHints.VALUE_TEXT_ANTIALIAS_DEFAULT);
Olga> + defaultHints.put (RenderingHints.KEY_STROKE_CONTROL, RenderingHints.VALUE_STROKE_DEFAULT);
Olga> [ ... ]
These lines go past 79 columns. I would suggest trying to split after
the ","s.
Olga> + boolean normalize = hints.containsValue (RenderingHints.VALUE_STROKE_NORMALIZE) ||
Olga> + hints.containsValue (RenderingHints.VALUE_STROKE_DEFAULT);
In the GNU style, operators come after a line break, not before. So
the `||' should appear at the start of the second line.
Tom