This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix for Dialog and FileDialog argument handling

From: Fernando Nasser <fnasser at redhat dot com>
To: tromey at redhat dot com
Cc: GCJ Patches <java-patches at gcc dot gnu dot org>
Date: Mon, 05 Jan 2004 10:26:00 -0500
Subject: Re: [PATCH] Fix for Dialog and FileDialog argument handling
Organization: Red Hat Canada
References: <3FF35C10.9010200@redhat.com> <87k7484wk5.fsf@fleche.redhat.com>

Tom Tromey wrote:

"Fernando" == Fernando Nasser <fnasser@redhat.com> writes:

Fernando> I wonder if this can be considered an obvious fix.

Yeah, I think so. Please check it in.
Fernando>   FileDialog(Frame parent, String title, int mode)
Fernando> +   throws IllegalArgumentException
Our standard is not to declare unchecked exceptions.
It makes sense to mention them in the javadoc though.

Noted. I will make this change before checking it in.

Thanks.

--
Fernando Nasser
Red Hat Canada Ltd.                     E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9

References:
- Re: [PATCH] Fix for Dialog and FileDialog argument handling
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]