Re: FYI: Patch: gnu.java.net.protocol.jar.Handler

[Guilhem Lavaux <guilhem at kaffe dot org>]

Michael Koch wrote:

> On Sat, Dec 20, 2003 at 10:12:34AM +0100, Guilhem Lavaux wrote:
>  
>
> > Michael Koch wrote:
> >
> >    
> >
> > > On Fri, Dec 19, 2003 at 06:45:42PM +0100, Guilhem Lavaux wrote:
> > >
> > >
> > >      
> > >
> > > > Michael Koch wrote:
> > > >
> > > >  
> > > >
> > > >        
> > > >
> > > > > On Fri, Dec 19, 2003 at 06:28:00PM +0100, Guilhem Lavaux wrote:
> > > > >
> > > > >
> > > > >    
> > > > >
> > > > >          
> > > > >
> > > > > > Michael Koch wrote:
> > > > > >
> > > > > >
> > > > > >
> > > > > >      
> > > > > >
> > > > > >            
> > > > > >
> > > > > > > Hi list,
> > > > > > >
> > > > > > >
> > > > > > > I commited the attached patch to merge 
> > > > > > > gnu.java.net.protocol.jar.Handler with classpath again. This also 
> > > > > > > fixes one mauve testcase and gives room for more fixes to jar URLs.
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > >  
> > > > > > >
> > > > > > >        
> > > > > > >
> > > > > > >              
> > > > > > I've already written something concerning Jar handlers and it appeared 
> > > > > > that sun is throwing an Error in the sub-handler if the jar URL is 
> > > > > > mispelled: it is then possible to throw an InvalidURLException (or 
> > > > > > something like that) in URL parsers when the URL is mispelled. To be 
> > > > > > able not to confuse things, I had overridden Error and throwed this 
> > > > > > "special" error in parseUrl.
> > > > > >
> > > > > > Unfortunately, the patch didn't come to classpath's CVS ...
> > > > > >
> > > > > >
> > > > > >      
> > > > > >
> > > > > >            
> > > > > Can you send me the patch for testing and probably commiting to libgcj
> > > > > while classpath CVS is still down ?
> > > > >
> > > > >
> > > > >
> > > > >    
> > > > >
> > > > >          
> > > > Here is the patch against my latest classpath snapshot. But please 
> > > > excuse me, I haven't fixed the spaces...
> > > >  
> > > >
> > > >        
> > > What does SUNs JRE ? Does it throw an instance of Error too ? Or does it
> > > simply ignore it somehow ? If it ignore it we should just do the same in
> > > classpath and libgcj
> > >
> > >      
> > Sorry, like an idiot I've forgotten to send you the last part of the 
> > patch. This translates URLParseError into MalformedURLException which 
> > the exception which is actually thrown by SUN's JRE.
> >    
>
> Hehe, and I really wondered.
>
>  
>
> > I've extracted a small test from kaffe's regression test URLTest.java: 
> > you may see that the two exceptions are thrown at the same point in 
> > java.net.URL so it seems that sun's jre is translating an error into 
> > another.
> >    
>
> Is that a testcast from Mauve testsuite ? It looks really familiar to
> me.
>  

Oh, yeah. Apparently someone merged it into 
gnu/testlet/java/net/newURL.java.

Guilhem.