This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [PATCH] [MinGW]: Reset/Ignore Thread Interruption for Plain[Datagram]SocketImpl
- From: Mohan Embar <gnustuff at thisiscool dot com>
- To: Michael Koch <konqueror at gmx dot de>
- Cc: GCJ Patches <java-patches at gcc dot gnu dot org>, tromey at redhat dot com
- Date: Mon, 15 Dec 2003 09:49:26 -0600
- Subject: Re: [PATCH] [MinGW]: Reset/Ignore Thread Interruption for Plain[Datagram]SocketImpl
- Reply-to: gnustuff at thisiscool dot com
>> >I dont know enough about the threading stuff. I would like if Tom or
>> >Bryce or Andrew can approve such type of changes. The other (case
>> >changing) things are okay.
>>
>> This is a Win32-specific patch, so I think that Tom empowered me to
>
>Ah, now I see, I commited the SocketTimeoutException stuff to the Posix
>part and we/you forgot it for the Win32 stuff until now.
Um, we're getting our patches confused here:
- the SocketTimeoutException is my POSIX patch. In natPlainDatagramSocketImplWin32,
I changed these from InterruptedIOExceptions to SocketTimeoutExceptions long
time ago with my cleanup/networking patch, but POSIX is still incorrect and needs
to be fixed.
May I commit this?:
http://gcc.gnu.org/ml/java-patches/2003-q4/msg00738.html
- the interruptible Selector.select() patch for Win32:
http://gcc.gnu.org/ml/java-patches/2003-q4/msg00733.html
I'm okay with this, but wanted to leave it on the list because Tom
sometimes catches formatting standards snafus and sometimes
makes insightful comments on the Win32 code.
- the reset/ignore thread interrupt status patch for Win32:
http://gcc.gnu.org/ml/java-patches/2003-q4/msg00736.html
My plan was to commit the latter two after letting them sit on the list
for a couple of days, but I need someone else's approval before
committing the first one.
-- Mohan
http://www.thisiscool.com/
http://www.animalsong.org/