This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [PATCH] [POSIX]: SocketTimeoutException for PlainDatagramSocketImpl + Minor Case Changes
- From: Mohan Embar <gnustuff at thisiscool dot com>
- To: Bryce McKinlay <bryce at mckinlay dot net dot nz>
- Cc: GCJ Patches <java-patches at gcc dot gnu dot org>, Michael Koch <konqueror at gmx dot de>
- Date: Sat, 13 Dec 2003 22:11:00 -0600
- Subject: Re: [PATCH] [POSIX]: SocketTimeoutException for PlainDatagramSocketImpl + Minor Case Changes
- Reply-to: gnustuff at thisiscool dot com
Hi Bryce,
>> This patch has PlainDatagramSocketImpl throw a
>> SocketTimeoutException instead of an InterruptedIOException
>> and has minor case changes for Plain[Datagram]SocketImpl
>> to make the output of the test attached to this post:
>>
>> http://gcc.gnu.org/ml/java-patches/2003-q4/msg00736.html
>>
>> ...diff more cleanly between Sun JRE 1.4.1 on Linux and
>> i686-pc-linux-gnu-gcj.
>
>Note that, in general, it doesn't matter if our exception messages do
>not exactly match those of the JDK - they arn't part of the spec. That
>said, I guess capitalising them does make them look better!
I agree. There are places in the MinGW port where I purposely let
the exception text diverge from Sun's JRE. This was more of a
"while-I'm-in-here" kind of a thing to make the diff smoother, the
main point being to replace the InterruptedIOException with the
SocketTimeoutException....
-- Mohan
http://www.thisiscool.com/
http://www.animalsong.org/