This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [PATCH] [MinGW]: Don't add dll[im/ex]port attributes to libgcj, unless dll build
- From: Mohan Embar <gnustuff at thisiscool dot com>
- To: tromey at redhat dot com
- Cc: java-patches at gcc dot gnu dot org, Danny Smith <dannysmith at users dot sourceforge dot net>
- Date: Tue, 11 Nov 2003 23:56:15 -0600
- Subject: Re: [PATCH] [MinGW]: Don't add dll[im/ex]port attributes to libgcj, unless dll build
- Reply-to: gnustuff at thisiscool dot com
Hi Tom,
Thanks for looking at this.
>This is ok. I have one comment, and one minor change I'd like you to
>make before committing.
>
>Mohan> (__GCJ_DLL__): New macro, controlling __GCJ_JNIIMPEXP__.
>
>I assume the plan is to define this macro when we are able to build
>libgcj as a DLL on Windows?
I assume so too. Conceivably, this could be done now by checking for
--enable-shared at configure time, but this seems like more trouble than
it's worth at this stage of the game, since I don't see a DLL build under
Windows for a long time to come. I don't know what your take on this
is.
>
>Mohan> +extern __GCJ_JNIIMPEXP__ jint JNICALL JNI_GetDefaultJavaVMInitArgs (void *);
>Mohan> +extern __GCJ_JNIIMPEXP__ jint JNICALL JNI_CreateJavaVM (JavaVM **, void **, void *);
>Mohan> +extern __GCJ_JNIIMPEXP__ jint JNICALL JNI_GetCreatedJavaVMs(JavaVM **, jsize, jsize *);
>
>Please wrap these lines at 80 columns, per the GNU coding standards.
Done and committed.
-- Mohan
http://www.thisiscool.com/
http://www.animalsong.org/