This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [PATCH] [MinGW]: Don't add dll[im/ex]port attributes to libgcj, unless dll build
- From: Tom Tromey <tromey at redhat dot com>
- To: gnustuff at thisiscool dot com
- Cc: java-patches at gcc dot gnu dot org, Danny Smith <dannysmith at users dot sourceforge dot net>
- Date: 10 Nov 2003 10:15:50 -0700
- Subject: Re: [PATCH] [MinGW]: Don't add dll[im/ex]port attributes to libgcj, unless dll build
- References: <TREDWTJE0VQN2MKS51YW65C7YT71.3fae94cf@p733>
- Reply-to: tromey at redhat dot com
>>>>> "Mohan" == Mohan Embar <gnustuff@thisiscool.com> writes:
Mohan> - Once Danny does this, can someone approve this?
This is ok. I have one comment, and one minor change I'd like you to
make before committing.
Mohan> (__GCJ_DLL__): New macro, controlling __GCJ_JNIIMPEXP__.
I assume the plan is to define this macro when we are able to build
libgcj as a DLL on Windows?
Mohan> +extern __GCJ_JNIIMPEXP__ jint JNICALL JNI_GetDefaultJavaVMInitArgs (void *);
Mohan> +extern __GCJ_JNIIMPEXP__ jint JNICALL JNI_CreateJavaVM (JavaVM **, void **, void *);
Mohan> +extern __GCJ_JNIIMPEXP__ jint JNICALL JNI_GetCreatedJavaVMs(JavaVM **, jsize, jsize *);
Please wrap these lines at 80 columns, per the GNU coding standards.
Tom