This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [JAVA PATCH] SAVE_EXPR evaluate-once semantics in jcf-write.c

From: Per Bothner <per at bothner dot com>
To: Andrew Haley <aph at redhat dot com>
Cc: java-patches at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
Date: Mon, 29 Sep 2003 11:57:24 -0700
Subject: Re: [JAVA PATCH] SAVE_EXPR evaluate-once semantics in jcf-write.c
References: <3F777FDE.1090703@bothner.com> <Pine.LNX.4.44.0309281806240.20936-100000@www.eyesopen.com> <16248.804.717178.60248@cuddles.cambridge.redhat.com>

Andrew Haley wrote:

 > To conclude, this patch is certainly not a workaround.  Whenever
 > generate_bytecode_insns encounters a SAVE_EXPR it has to ensure
 > that its only ever evaluated once.  Those are the semantics of
 > SAVE_EXPR.  Even if we eventually manage to remove/replace all
 > SAVE_EXPRs from the tree, the SAVE_EXPR case of this switch either
 > needs the implementation proposed by my patch or to call abort.
 > The current scheme of silently generating bad code is "right out".

True. I'm minded to accept this patch, but I'll defer to Per.


Likewise (except for the defer-to-Per part!).
--
	--Per Bothner
per@bothner.com   http://per.bothner.com/

References:
- Re: [JAVA PATCH] SAVE_EXPR evaluate-once semantics in jcf-write.c
  - From: Per Bothner
- Re: [JAVA PATCH] SAVE_EXPR evaluate-once semantics in jcf-write.c
  - From: Roger Sayle
- Re: [JAVA PATCH] SAVE_EXPR evaluate-once semantics in jcf-write.c
  - From: Andrew Haley

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]