This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: FYI: Patch: java.text.SimpleDateFormat merge from classpath

From: Bryce McKinlay <bryce at mckinlay dot net dot nz>
To: Michael Koch <konqueror at gmx dot de>
Cc: java-patches at gcc dot gnu dot org,Guilhem Lavaux <guilhem at kaffe dot org>
Date: Fri, 26 Sep 2003 15:43:25 +1200
Subject: Re: FYI: Patch: java.text.SimpleDateFormat merge from classpath

On Friday, Sep 26, 2003, at 05:27 Pacific/Auckland, Michael Koch wrote:

I commited the attached patch to trunk to merge
java.text.SimpleDateFormat with classpath again.

+2003-09-25  Guilhem Lavaux  <guilhem@kaffe.org>
+
+	* java/text/SimpleDateFormat.java (parse): Don't use class calendar
+	field.

This patch doesn't look right. We don't want to be cloning the calendar object on every parse() call - its a big performance penalty. If calendar.clear() is not correctly reseting the calendar instance, then the bug is in Calendar, not SimpleDateFormat.

Guilhem, could you explain the motivation behind this change?

Regards

Bryce

Follow-Ups:
- Re: FYI: Patch: java.text.SimpleDateFormat merge from classpath
  - From: Guilhem Lavaux

References:
- FYI: Patch: java.text.SimpleDateFormat merge from classpath
  - From: Michael Koch

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]