Re: gcc/libjava ChangeLog Makefile.am Makefile.in ...

[Bryce McKinlay <bryce at mckinlay dot net dot nz>]

On Wednesday, Sep 24, 2003, at 17:54 Pacific/Auckland, Michael Koch 
wrote:

> > Removed files:
> > 	libjava/gnu/java/net: SocketInputStream.java
> > 	                      SocketOutputStream.java
>
> Why have you remove these before waiting for a discussion ?
> I would really appreciate discussion about such stuff first.

For the record: Michael also emailed me privately about this and we 
worked it out. Here was my response:

> Sorry Michael - I just realised that I forgot to mention this in the 
> message I posted to java-patches. I removed these files because they 
> are unused - they have equivalents in the inner classes 
> PlainSocketImpl.SocketOutputStream and 
> PlainSocketImpl.SocketInputStream. Implementing them as an inner class 
> is a better design, I believe, because the java part is very small & 
> simple, they are always 1:1 associated with an instance of 
> PlainSocketImpl, and they rely on instance fields from 
> PlainSocketImpl. In addition to this, the native parts are elegantly 
> implemented in a single file (for each native platform).

We agreed that the classpath's PlainSocketImpl.java should be updated 
based on the libgcj's implementation.

Regards

Bryce.