This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch: new methods in gnu.java.net.Plain(Datagram)SocketImpl ?


>>>>> "Mohan" == Mohan Embar <gnustuff@thisiscool.com> writes:

Mohan> What ever became of this?:
Mohan> http://gcc.gnu.org/ml/java/2003-04/msg00242.html

As I understand it, this would change us from having final methods to
virtual methods for everything in FileDescriptor.  With the new ABI,
that's unlikely to be a performance penalty.

And it does seem a bit cleaner.

There are two open questions, still:

- What is the security model?
- Will this approach be suitable for java.nio?

And, I think, this really needs to be discussed and implemented in
classpath first.


Some of the sample code (AG supplied some, if you read through the
thread you can find a link) is kind of gross, imo.  For instance, now
FileInputStream has two fields, "fd" and "pfd".  Other aspects of the
code are clearly cleaner though, for instance "PlatformFileDescriptor"
is a nice abstract base class.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]