This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Mohan's Outstanding Patches
- From: Tom Tromey <tromey at redhat dot com>
- To: gnustuff at thisiscool dot com
- Cc: java-patches at gcc dot gnu dot org
- Date: 28 Aug 2003 17:13:04 -0600
- Subject: Re: Mohan's Outstanding Patches
- References: <RNYWD0FA0OJLHPMOEAB7VUUQJFS09.3f4bf4b4@p733>
- Reply-to: tromey at redhat dot com
>>>>> "Mohan" == Mohan Embar <gnustuff@thisiscool.com> writes:
>> I skimmed quickly through the rest of the changes. It all looks
>> pretty reasonable to me. It also looks Win32-specific, so I won't be
>> doing a deeper review.
Mohan> Given that the refactoring I did for my cleanup/networking
Mohan> patch (JStringToCString + no namespace + moving a header file
Mohan> to win32.h) is pretty trivial, I am not clear on whether your
Mohan> saying that the first version was pretty reasonable and that
Mohan> you wouldn't be doing a deeper review consititutes check-in
Mohan> approval for the slightly-altered patch or not.
I was just looking at coding style type stuff. I can't really comment
on the Windows-specific bits.
I've sort of lost track of who is approving Windows patches :-). If
it is you (or nobody in particular), then by all means, go for it.
Let's also update MAINTAINERS to reflect this info.
Tom