This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Eliminate natVMSecurityManager.cc warning
- From: Matt Kraai <kraai at alumni dot cmu dot edu>
- To: java-patches at gcc dot gnu dot org
- Date: Tue, 17 Jun 2003 23:05:18 -0700
- Subject: Eliminate natVMSecurityManager.cc warning
Howdy,
natVMSecurityManager.cc generates the following warning:
../../../../gcc/libjava/java/lang/natVMSecurityManager.cc: In static member
function `static JArray<java::lang::Class*>*
java::lang::VMSecurityManager::getClassContext()':
../../../../gcc/libjava/java/lang/natVMSecurityManager.cc:28: warning: unused
variable `int maxlen'
It appears that
* java/lang/natVMSecurityManager.cc (getClassContext): Fix
infinite loop.
incorrectly replaced maxlen with len. The following patch changes
it back to maxlen.
Rebuilt and regression tested libjava on
powerpc-unknown-linux-gnu, and checked that the warning was
eliminated.
I can commit to the GCC repository but not to the Classpath
repository.
OK to commit?
--
Matt Kraai kraai@alumni.cmu.edu Debian GNU/Linux
* java/lang/natVMSecurityManager.cc (getClassContext):
Use maxlen instead len for loop bound.
Index: libjava/java/lang/natVMSecurityManager.cc
===================================================================
RCS file: /cvs/gcc/gcc/libjava/java/lang/natVMSecurityManager.cc,v
retrieving revision 1.2
diff -3 -c -p -r1.2 natVMSecurityManager.cc
*** libjava/java/lang/natVMSecurityManager.cc 12 Jun 2003 15:39:17 -0000 1.2
--- libjava/java/lang/natVMSecurityManager.cc 17 Jun 2003 08:06:20 -0000
*************** java::lang::VMSecurityManager::getClassC
*** 28,34 ****
int maxlen = t->length();
int len = 0;
! for (int i=0; i<len; i++)
{
jclass klass = t->classAt(i);
if (klass != NULL && klass != &java::lang::VMSecurityManager::class$
--- 28,34 ----
int maxlen = t->length();
int len = 0;
! for (int i=0; i<maxlen; i++)
{
jclass klass = t->classAt(i);
if (klass != NULL && klass != &java::lang::VMSecurityManager::class$
*************** java::lang::VMSecurityManager::getClassC
*** 41,47 ****
NULL);
len = 0;
! for (int i=0; i<len; i++)
{
jclass klass = t->classAt(i);
if (klass != NULL && klass != &java::lang::VMSecurityManager::class$
--- 41,47 ----
NULL);
len = 0;
! for (int i=0; i<maxlen; i++)
{
jclass klass = t->classAt(i);
if (klass != NULL && klass != &java::lang::VMSecurityManager::class$