This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Patch: Account for possible null laddr in Socket.java
- From: Mohan Embar <gnustuff at thisiscool dot com>
- To: Michael Koch <konqueror at gmx dot de>
- Cc: GCJ Patches <java-patches at gcc dot gnu dot org>
- Date: Tue, 17 Jun 2003 13:01:25 -0500
- Subject: Re: Patch: Account for possible null laddr in Socket.java
- Reply-to: gnustuff at thisiscool dot com
HI Michael,
>I have written a new patch for this. Please review and comment.
This looks nice. I especially like how you've cleaned things up
and are explicitly testing for things. Everything I saw seemed
in conformance with the JavaDoc, and I tested the Socket
constructor on the JRE and it threw a NullPointerException
just like you coded.
-- Mohan
http://www.thisiscool.com/
http://www.animalsong.org/