Re: [PATCH] Fix and cleanup libjava/include/dwarf2-signal.h

[Franz Sirl <Franz dot Sirl-kernel at lauterbach dot com>]

On Friday 13 June 2003 14:21, Andrew Haley wrote:
> This is the wrong list for this patch; I have redirected accordingly.

You had a typo in the redirection and I think my reply on Friday didn't reach 
you (can't find it in the lists).

> Franz Sirl writes:
>  > Hi,
>  >
>  > the INIT_SEGV and INIT_FPE macros in dwarf2-signal.h are broken for
>  > Linux where the userspace and kernelspace struct sigaction differ. Due
>  > to this the SA_SIGINFO flag is never honored.
>  > The appended patch fixes that and adds a reference to MAKE_THROW_FRAME
>  > to the MD_FALLBACK_FRAME_STATE_FOR documentation. I also took the
>  > opportunity to cleanup, reorder and indent the #if/#elif/#endif maze in
>  > dwarf2-signal.h, as discussed on IRC.
>
> Good.  It's much tidier if each machine has its own signal handler in
> include/machine.h.
>
>  > In a followup patch I will add a MAKE_THROW_FRAME for ppc-linux and fix
>  > MD_FALLBACK_FRAME_STATE_FOR in rs6000/linux.h accordingly.
>  >
>  > Bootstrapped and regtested on i686-linux.
>
> i686-linux uses include/i386-signal.h, so regtesting on that platform
> didn't test much.
>
>  > OK to commit to mainline and 3.3?
>
> OK.  However, this patch conflicts with the cleanup I posted
> yesterday.  You'll need to do a 'cvs update' on mainline.

Hi Andrew,

for now I've only committed the doc part. I retract my original patch to 
dwarf2-signal.h, as it will break alpha-linux (I looked closer after you 
pointed out that i386-linux is no valid test platform).

Since I already did the tidyup work, here the patch again with the "#elif 
defined(__linux__)" hunk removed, thus it's only a reformatting patch now.

OK to commit to mainline?

Nevertheless signal-handling on alpha-linux should be fixed, but I'll leave 
this to Richard or someone else who can test it on alpha-linux.

Franz.

	* include/dwarf2-signal.h: Tidy and reorder.

Attachment: gcc-libjava-3.patch
Description: Text document