This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: PATCH: xlib arcs and ovals
- From: Tom Tromey <tromey at redhat dot com>
- To: "Scott Gilbertson" <scottg at mantatest dot com>
- Cc: <java-patches at gcc dot gnu dot org>
- Date: 11 Jun 2003 09:53:35 -0600
- Subject: Re: PATCH: xlib arcs and ovals
- References: <013f01c33031$74f0ba50$3c16a8c0@mantatest.com>
- Reply-to: tromey at redhat dot com
>>>>> "Scott" == Scott Gilbertson <scottg@mantatest.com> writes:
Scott> Index: libjava/ChangeLog
Scott> from Scott Gilbertson <scottg@mantatest.com>
Scott> * gnu/awt/j2d/IntegerGraphicsState.java (drawOval): implemented.
Scott> (fillOval): implemented
These are easier for me to handle if the ChangeLog entry is properly
formatted -- in this case a leading tab is required.
Scott> + drawArc (x,y,width,height,0,360);
You need spaces after the commas. There are a few instances of this.
Scott> + XDrawArc(dpy, drawableXID, gc, x, y, w, h, startAngle*64, arcAngle*64);
Spaces around the "*"s.
Scott> + // no fast fail
What does this comment mean?
Otherwise this is fine.
Tom