Re: Patch for Preview: _Jv_ThisExecutable (The Saga Continues)

[Andrew Haley <aph at redhat dot com>]

Mohan Embar writes:
 > 
 > >This breaks JvCreateJavaVM, because _Jv_argv isn't necessarily set.
 > >Please check _Jv_argv != NULL before doing this.
 > 
 > Sorry about this. I'll redo the patch and resubmit it ASAP. I'll need to retest
 > the various build combinations so I'll shoot for submitting this sometime tomorrow
 > at the latest.
 > 
 > >BTW, is there any reason 
 > >
 > > > +extern int _Jv_argc;
 > > > +extern const char **_Jv_argv;
 > >
 > >isn't in some header file?
 > 
 > You're right about this too. I'll do this in the patch I resubmit.
 > 
 > Sorry again for the inconvenience.

No problem.  If you contribute patches, you sometimes contribute bugs.
We are imperfect beings.

The real problem here is that none of our regression tests caught
this.

Andrew.