This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Outstanding patches

Ranjit Mathew writes:
 > >  > Index: ChangeLog
 > >  > from  Ranjit Mathew  <rmathew at hotmail dot com>
 > >  > 
 > >  >  * jcf-parse.c (set_source_filename): Use COMPARE_FILENAMES
 > >  >  instead of strcmp to compare file names. 
 > >  >  Use IS_DIR_SEPARATOR instead of directly comparing to
 > >  >  '/' and '\\'.
 > >  > 
 > >  >  * jcf-write.c (generate_classfile): Use IS_DIR_SEPARATOR 
 > >  >  instead of directly comparing to '/' and '\\'.
 > > 
 > > What does this fix?
 > 
 > This (and the one following it, merged into a common patch later)
 > are not "fixing" anything as such, but IMHO are The Right Thing
 > To Do w.r.t. directory separators.

Right.  You must say what a patch does, because I'm not checking
anything that is not a bug fix into 3.3.

 > The file names/name-component comparisons bits are obviously (to
 > me) the right thing to do if one has a case-insensitive filesystem.

Sure.  Are there going to be any more?  I'm going to wait for a grand
one shot patch that fixes all of these.

Andrew.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]