This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Patch: Suppress MingW Build-Busting Net Code
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Am Dienstag, 11. März 2003 07:01 schrieb Ranjit Mathew:
> >> I know the #ifdefs are ugly, but they currently run rampant in
> >> java.net and they unbreak the MingW build while waiting for the
> >> glorious day that we properly split out the code. Your call...
>
> Michael, this refers to an earlier thread on the GCJ list where you
> and Adam agreed that it would be better to split the java.net
> code instead of #ifdef-ing for platform specifics. Are you working
> on this or is it on your TODO list?
Aah, yes. I have some code for this in my tree. Mainly it moves the
code to win32.* and posix.* and then we can use the code from
java.net and java.nio and need no #ifdefs in java.net/nio anymore.
I thinks I should slowly submit the patches for this.
> >> * gnu/java/nio/natSelectorImpl.cc (java_do_select): #ifdef
> >> out functionality not implemented under mingw (_Jv_select())
> >
> >The correct solution would be to add a dummy _Jv_select to
> >libjava/win32.cc.
>
> BTW, Win32 does have a select( ) so this need not be dummy
> as such.
Can you provide a patch implementing it in win32.cc ? Tom can then
approve it.
Michael
- --
Homepage: http://www.worldforge.org/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
iD8DBQE+bYR7WSOgCCdjSDsRAmayAJ4g+vXlanQpCbiZvG4FrODwAE8lqACeLhq4
iL5m+gHCrCqNacz7aP4ok9A=
=7Ei/
-----END PGP SIGNATURE-----