This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Patch: natSocketChannelImpl.cc use elements + explicit cast
- From: Michael Koch <konqueror at gmx dot de>
- To: gnustuff at thisiscool dot com, GCJ Patches <java-patches at gcc dot gnu dot org>
- Date: Mon, 10 Mar 2003 16:27:56 +0100
- Subject: Re: Patch: natSocketChannelImpl.cc use elements + explicit cast
- References: <CANL4OJE9341USLFKEKDACAROA573.3e697d59@p733>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Am Samstag, 8. März 2003 06:19 schrieb Mohan Embar:
> This patch addresses something that broke under the MingW build,
> possibly because jbyte seems to be unsigned char and not signed
> char on Win32. It also appeared to me that "elements(data)" was
> needed instead of just plain "data". Am I right?
>
> Also see my comment about the cast to char* instead of const char*
> in ::send().
> 2003-03-07 Mohan Embar <gnustuff at thisiscool dot com>
>
> * gnu/java/nio/natSocketChannelImpl.cc (SocketRead): use
> elements(data) and explicitly cast to char* on platforms
> where jbyte is not signed char
> (SocketWrite): idem
Looks okay. Should I commit it ?
Michael
- --
Homepage: http://www.worldforge.org/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
iD8DBQE+bK78WSOgCCdjSDsRAi7+AKCMKok0/CB2mD4lRutckLSdXfbWSQCfRD/9
NUAhe5hzJ7G1U3QyReLucvA=
=k4aI
-----END PGP SIGNATURE-----