Re: Outstanding patches

["Ranjit Mathew" <rmathew4lists at hotmail dot com>]

> > I might have some time this weekend to look at outstanding patches.
> > 
> > Please remind me of any patches that want attention.
> 
[...]
> In addition, I noticed that the following is desirable:

...as are the following (trivial) changes:

(I wanted to make similar changes in "jvspec.c" where it looks for 
".zip", ".jar" and ".java" file extensions on the command line, but 
it doesn't include "jcf.h" - more importantly however, Sun's JDK 1.4.1 
does not accept "Foo.JAVA" on Win32 instead of "Foo.java" on the javac 
command line, so this is not needed anyways. Weirdly though, it does 
accept "foo.java".)


Index: ChangeLog
from  Ranjit Mathew  <rmathew at hotmail dot com>

 * jcf-io.c (opendir_in_zip): Use COMPARE_FILENAMES
 instead of strcmp to compare file names.
 (compare_path): Likewise.
 (memoized_dirlist_lookup_eq): Likewise.

Index: jcf-io.c
===================================================================
--- jcf-io.c Fri Mar  7 17:03:06 2003
+++ jcf-io.c Fri Mar  7 17:12:22 2003
@@ -113,5 +113,5 @@
   for (zipf = SeenZipFiles;  zipf != NULL;  zipf = zipf->next)
     {
-      if (strcmp (zipf->name, zipfile) == 0)
+      if (COMPARE_FILENAMES (zipf->name, zipfile) == 0)
  return zipf;
     }
@@ -284,6 +284,6 @@
 compare_path (const void *key, const void *entry)
 {
-  return strcmp ((const char *) key, 
-   (*((const struct dirent **) entry))->d_name);
+  return COMPARE_FILENAMES ((const char *) key, 
+              (*((const struct dirent **) entry))->d_name);
 }
 
@@ -318,6 +318,6 @@
 memoized_dirlist_lookup_eq (const void *entry, const void *key)
 {
-  return strcmp ((const char *) key,
-   ((const memoized_dirlist_entry *) entry)->dir) == 0;
+  return COMPARE_FILENAMES ((const char *) key,
+              ((const memoized_dirlist_entry *) entry)->dir) == 0;
 }