This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [PATCH] gnu.java.nio.FileChannelImpl - hack - comments appreciated
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Am Sonntag, 2. März 2003 01:07 schrieb Tom Tromey:
> >>>>> "Michael" == Michael Koch <konqueror at gmx dot de> writes:
>
> Michael> I made a little patch to make gnu.java.nio.FileChannelImpl
> more Michael> working in trunk. Unfortunately it uses an IMO ugly
> hack:
>
> Michael> It uses native methods to access the package private
> methods from Michael> java.io.FileDescriptor. Is this allowed ?
> Should it be avoided ? What Michael> should be done ?
>
> This is definitely allowed. We already do this with FileDescriptor
> in java.net; there's even a comment in FileDescriptor explaining
> that we do it. I know we do it in other cases as well. It is a
> bit ugly, but not really worse than the alternatives.
Okay, I commited this now to trunk. Now I will be able to submit
patches for a more working version of gnu.java.nio and the java.io
patch to acces FileChannels.
Michael
- --
Homepage: http://www.worldforge.org/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
iD8DBQE+YipYWSOgCCdjSDsRAtouAKCUd/k+kcwAh+qXOzRWcTP64m70iACdGjhH
eRKl8jg3I1uUM4RnxnR3ilk=
=2S0r
-----END PGP SIGNATURE-----