This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] java.net.DatagramSocket


>>>>> "Michael" == Michael Koch <konqueror at gmx dot de> writes:

Michael> Here a patch to fix some things in DatagramSocket.
Michael> Please review and comment.

Looks good to me; I've put this in 3.3.


Michael>      catch (UnknownHostException ex)
Michael>        {
Michael> -	// FIXME: This should never happen, so how can we avoid this construct?
Michael> -	return null;
Michael> +        // FIXME: This should never happen, so how can we avoid this construct?
Michael> +        return null;

We could throw some InternalError here.  I'm so-so on that idea.

Otherwise, there's nothing to do; we can just remove the FIXME.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]