Re: Possible awt patches

[Tom Tromey <tromey at redhat dot com>]

>>>>> "Hans" == Boehm, Hans <hans_boehm@hp.com> writes:

Hans> Here is a bigger version of the patch.  It fixes enough bugs to
Hans> almost make CRCalc usable.  (CRCalc works if you use purely the
Hans> mouse and not the keyboard.)  I have a bit more confidence in
Hans> this version as a result.

This looks good to me.

Hans> I'm still not positive about the guesses for getPreferredSize.
Hans> If I take those out, I get NullPointerExceptions on the result,
Hans> but those seem to be caught somewhere.  I'd be inclined to put
Hans> in the guess, simply because it makes debugging easier.

Yeah.  Did you try to find out what the JDK does in this situation?

Hans> The setFont part of the patch is also a bit dubious.  I don't
Hans> think it's quite doing the right thing.
Hans> [ ... ]
Hans> Hence I would like to check it in, at least in the absence of a
Hans> better patch by a GTK expert.

Sounds good.

Hans> OK for trunk?  What about 3.3?

I've only been putting AWT fixes on the trunk since the peers aren't
in 3.3.

There are a couple places in the patch where `return (...)' should be
written without the parens.  Please fix those.

Finally, can you check this in to Classpath as well?  If not, send me
the updated patch and I will do it.  The AWT code is kept in pretty
close synchronization (which reminds me; some AWT changes went into
Classpath recently; I'll bring them over in the near future.)

Tom