This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [PATCH] java.awt
- From: Tom Tromey <tromey at redhat dot com>
- To: Michael Koch <konqueror at gmx dot de>
- Cc: java-patches at gcc dot gnu dot org
- Date: 14 Feb 2003 10:22:46 -0700
- Subject: Re: [PATCH] java.awt
- References: <200302141155.26238.konqueror@gmx.de>
- Reply-to: tromey at redhat dot com
>>>>> "Michael" == Michael Koch <konqueror@gmx.de> writes:
Michael> I have written another java.awt patch. This mostly implements some
Michael> missing methods (getListeners and friends) and removes some unneeded
Michael> "implements Serializable". Please review and comment.
Looks great, though I have one question (see below).
Michael> Of course this should go into classpath too.
Yes, thanks.
BTW if you ever feel like reindenting some of the old-style AWT code,
feel free. Just do it as a separate reformatting patch; simple
formatting changes don't require approval.
Michael> + return Class.forName ("java.nio.ByteBuffer")
Michael> + .isAssignableFrom (representationClass);
I'm curious about this code.
Why not use instanceof? java.nio.ByteBuffer is in both code bases,
and is compiled. I'd prefer this, unless there's a reason against it.
Tom