This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [PATCH] java.awt
- From: Tom Tromey <tromey at redhat dot com>
- To: Michael Koch <konqueror at gmx dot de>
- Cc: java-patches at gcc dot gnu dot org
- Date: 12 Feb 2003 12:57:11 -0700
- Subject: Re: [PATCH] java.awt
- References: <200302121148.41677.konqueror@gmx.de>
- Reply-to: tromey at redhat dot com
>>>>> "Michael" == Michael Koch <konqueror@gmx.de> writes:
Michael> This patch fixes some glitches in java.awt. Please review and
Michael> comment.
Thanks for doing this.
Note that java.awt is (with the exception of a minor change in
Toolkit) fully merged with Classpath. (Well, there are a couple
Classpath changes I haven't yet brought over...) Changes have to go
in to Classpath as the same time.
I didn't look to make sure that the spec changes you made are correct.
I'm sure they are though.
Michael> +++ /home/mkoch/src/gcc-work/libjava/java/awt/Polygon.java 2003-02-12 08:33:09.000000000 +0100
Michael> @@ -120,6 +120,7 @@
Michael> // Leave room for growth.
Michael> xpoints = new int[4];
Michael> ypoints = new int[4];
Michael> + npoints = 4;
Michael> }
I think this patch is incorrect. `npoints' is the number of points in
the polygon, but this constructor makes an empty polygon. The "[4]"s
because we assume the user will add a point or two, and we don't want
to immediately grow it.
The rest of this is fine. Please commit.
Tom