This is the mail archive of the
mailing list for the Java project.
Re: Patch: Indicate EOF on Win32 when ReadFile( ) returns with ERROR_BROKEN_PIPE
- From: Tom Tromey <tromey at redhat dot com>
- To: Ranjit Mathew <rmathew at hotmail dot com>
- Cc: java-patches at gcc dot gnu dot org
- Date: 11 Feb 2003 13:46:56 -0700
- Subject: Re: Patch: Indicate EOF on Win32 when ReadFile( ) returns with ERROR_BROKEN_PIPE
- References: <3E493FE7.94B4C7DD@hotmail.com>
- Reply-to: tromey at redhat dot com
>>>>> "Ranjit" == Ranjit Mathew <firstname.lastname@example.org> writes:
Ranjit> This patch proposes to change the read( ) methods in
Ranjit> java/io/natFileDescriptorWin32.cc so that they return a
Ranjit> -1 (EOF) when ReadFile( ) returns with a Win32 error
Ranjit> code of ERROR_BROKEN_PIPE when reading from a pipe.
Looks good. I'm checking it in to 3.3 and 3.4.
BTW this one applied cleanly.
Ranjit> PS: How does one write ChangeLog entries for overloaded
Ranjit> methods like read( ) in the following example?
It depends. Sometimes I just write the plain name, like you did. If
I want to emphasize which particular one I changed, I put the argument
types in parens, like `foo(int,String)'.