This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch: Indicate EOF on Win32 when ReadFile( ) returns with ERROR_BROKEN_PIPE


>>>>> "Ranjit" == Ranjit Mathew <rmathew@hotmail.com> writes:

Ranjit>    This patch proposes to change the read( ) methods in 
Ranjit> java/io/natFileDescriptorWin32.cc so that they return a
Ranjit> -1 (EOF) when ReadFile( ) returns with a Win32 error
Ranjit> code of ERROR_BROKEN_PIPE when reading from a pipe.

Looks good.  I'm checking it in to 3.3 and 3.4.

BTW this one applied cleanly.

Ranjit> PS: How does one write ChangeLog entries for overloaded
Ranjit> methods like read( ) in the following example?

It depends.  Sometimes I just write the plain name, like you did.  If
I want to emphasize which particular one I changed, I put the argument
types in parens, like `foo(int,String)'.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]