This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch: Include platform.h in gnu/gcj/runtime/natStackTrace.cc


Ranjit Mathew writes:
 > Andrew Haley wrote:
 > > For example: say you read your program source and discover that some
 > > code is conditional on HAVE_BACKTRACE, so you look in include/config.h
 > > and discover that variable isn't set.  However, it *is* set, whatever
 > > config.h says, just somewhere else.  And because you have two
 > > contradictory defintions of HAVE_BACKTRACE the result depends on what
 > > order platform.h and config.h are included.  ARgh!
 > 
 > I agree totally with what you say and the configure.in thingy is what
 > I had done on my first attempt. However, you must realise that we also
 > need the prototype for backtrace( ) which doesn't belong to config.h
 > AFAICT.
 > 
 > The other choices with me were to either include platform.h or to
 > have conditional (on WIN32 being defined) code in natStackTrace.cc
 > that declares the prototype for backtrace( ).

I have no object at all do #including platform.h, but don't define
HAVE_BACKTRACE there, please!  platform.h is a good place for the
backtrace() prototype.

Andrew.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]