This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] Fix for PR/9253: File.listFiles( ) Error on Win32


>>>>> "Ranjit" == Ranjit Mathew <rmathew@hotmail.com> writes:

Ranjit> This patch fixes PR/9253 as reported by Erik on the main list.

Thanks.  I'm checking this in to 3.3 and the trunk.

FYI, if a patch fixes a PR, put something like this in the ChangeLog
entry:

	Fixes PR java/9253:

The text `PR ' must be there exactly, and the category must be
correct.  If this is done then the commit message will end up in the
PR.

Ranjit>     // FIXME?
Ranjit> -  strcpy(&buf[total], "\\*.*");
Ranjit> +  if (buf[total-1] == '\\')

I've removed the FIXME.


Also, despite what the gcc rules say, it would be more convenient for
me if the ChangeLog were simply part of the patch.  That way I can use
my tools here to just apply it directly.  It is also more convenient
for me if patches are made from either the gcc or libjava directory
(this patch was fine on that count); I have preset keys in my MUA to
apply patches if they are made that way...

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]