This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: java.awt - documentation and others - REVISED
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Am Dienstag, 14. Januar 2003 20:41 schrieb Tom Tromey:
> >>>>> "Michael" == Michael Koch <konqueror@gmx.de> writes:
>
> Michael> Here a better version of the patch.
>
> This looks good to me, though see the comments below first. Please
> check it in: cvs trunk, 3.3, and Classpath (especially the latter
> since Classpath is the master source for AWT). I can do this if
> you like.
>
> Michael> - */
> Michael> graphicsConfiguration = gc;
>
> This line needs to be reindented.
I (and xemacs gnu-indent-style) really see no reason to reindent it in
the source. Perhaps its just looking bad in the patch ....
> Michael> + bits_sum += bits [i];
>
> I think it is clearer to use `|=' here.
> Also it avoids any potential overflow problems.
Okay, commited.
Can you please commit this too 3_3_branch ?
Michael
- --
Homepage: http://www.worldforge.org/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
iD8DBQE+JIHoWSOgCCdjSDsRAv8zAKCWoIRCsx4Zr4pPl61PFMn3IP0yeACdGPa/
nXR7KPKBpHfqcwvezfjDyWQ=
=cMYN
-----END PGP SIGNATURE-----