This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: BigInteger.modInverse() fix
- From: Tom Tromey <tromey at redhat dot com>
- To: Per Bothner <per at bothner dot com>
- Cc: Mark Wielaard <mark at klomp dot org>, java-patches at gcc dot gnu dot org, raif at fl dot net dot au
- Date: 15 Dec 2002 23:17:02 -0700
- Subject: Re: BigInteger.modInverse() fix
- References: <1039966534.16025.384.camel@elsschot><3DFCDA19.5020408@bothner.com>
- Reply-to: tromey at redhat dot com
>>>>> "Per" == Per Bothner <per@bothner.com> writes:
Per> Would it make sense to do:
Per> rem = rem.canonicalize();
Per> quot = quot.canonicalize();
Per> It probably doesn't matter.
Are rem and quot guaranteed not to be small?
If so, at least a comment is warranted.
If not, the above must be done.
Per> Instead of allocating a BigInteger at each level of
Per> recursion, maybe you could modify euclidInv to:
The code already has a FIXME about its inefficient use of memory. So
I think making this change isn't a requirement for the patch. OTOH,
if Mark or Raif want to do it, that would be great.
Tom